Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-1809 Returning user dashboard chart #3259

Merged
merged 6 commits into from
Jul 27, 2023

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Jul 27, 2023

References:

Jira: MNTOR-1809
Figma: https://www.figma.com/file/CaEKIhvSJqf6KNIMzSkt40/Concepts-for-Monitor-MVP-Redesign?type=design&node-id=1403-83261&mode=design&t=0FZmqDqjHHlIwrgx-4

This adds the dashboard banner state for returning users who haven't run a scan.

Screenshot (if applicable)

image

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@codemist codemist changed the title MNTOR-1809 Returning user view MNTOR-1809 Returning user dashboard chart Jul 27, 2023
@pdehaan
Copy link
Collaborator

pdehaan commented Jul 27, 2023

nit: this screenshot (from above) is a bit weird because we're showing Email addresses 0×.
Shouldn't we be filtering out labels that aren't in the donut?
I'd have to look at the code again, but if we have no email addresses but 3 in "other" was there nothing else we could have shown in the donut chart? Or is this just the curse of mock data?

Screenshot 2023-07-27 at 8 55 50 AM

@codemist codemist force-pushed the mntor-1809-returning-user-scan branch from 0988cea to 8669e27 Compare July 27, 2023 19:53
@codemist codemist changed the base branch from main to MNTOR-1942 July 27, 2023 19:53
@codemist codemist marked this pull request as ready for review July 27, 2023 19:55
@codemist codemist requested a review from flodolo as a code owner July 27, 2023 19:55
@codemist codemist requested a review from mansaj July 27, 2023 19:55
@codemist
Copy link
Collaborator Author

@pdehaan Fixed in #3260

Copy link
Collaborator

@mansaj mansaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont worry about the build failures, I'll deal with it on the base branch

@mansaj
Copy link
Collaborator

mansaj commented Jul 27, 2023

Thanks!

@mansaj mansaj merged commit 240b18e into MNTOR-1942 Jul 27, 2023
1 of 2 checks passed
@mansaj mansaj deleted the mntor-1809-returning-user-scan branch July 27, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants