Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breach alert email redesign #5012

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Breach alert email redesign #5012

merged 7 commits into from
Sep 17, 2024

Commits on Sep 17, 2024

  1. Redirect to the correct step from /fix

    @Vinnl
    Vinnl committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3f33c1d View commit details
    Browse the repository at this point in the history

  2. Add redesigned breach alert email (behind flag)

    @Vinnl
    Vinnl committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    05ece9e View commit details
    Browse the repository at this point in the history

  3. Move redesigned footer into separate component 

    It's intended to be used in every email, so I moved it out for now.
Let's see if we actually get around to updating the other emails 😅
    @Vinnl
    Vinnl committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4efd9eb View commit details
    Browse the repository at this point in the history

  4. Limit footer bg colour to bg image width

    @Vinnl
    Vinnl committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f00f5ae View commit details
    Browse the repository at this point in the history

  5. Apply redesigned footer text changes

    @Vinnl
    Vinnl committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    45eb43a View commit details
    Browse the repository at this point in the history

  6. Only fetch scans/breaches with flag enabled 

    In case they cause too much load, we can easily disable the flag
again.
    @Vinnl
    Vinnl committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    76eda09 View commit details
    Browse the repository at this point in the history

  7. Only collect scan & breach data when needed 

    When processing tens of thousands of breach notifications, we might
theoretically be hammering the database by running a bunch of
queries for each of those notifications. It's currently hard to
test whether that load is actually excessive, but to be sure, this
refactors it to only load that data if it is absolutely necessary.
(Which currently is just for the free US user who has run a scan,
where we display the number of unfixed results.)
    @Vinnl
    Vinnl committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bffd2a6 View commit details
    Browse the repository at this point in the history