Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address some of the flaky E2E tests #5106

Merged
merged 14 commits into from
Oct 1, 2024
Merged

Address some of the flaky E2E tests #5106

merged 14 commits into from
Oct 1, 2024

Conversation

flozia
Copy link
Collaborator

@flozia flozia commented Sep 27, 2024

This PR addresses some of the flaky E2E tests. The dashboard and landing test groups were split into their own .spec files for better parallel execution.

@flozia flozia self-assigned this Sep 27, 2024
Copy link

@flozia flozia changed the title WIP: Address some of the flaky E2E tests Address some of the flaky E2E tests Sep 28, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test groups from dashboard.spec.ts were split into multiple dashboard-*.spec.ts files.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test groups from landing.spec.ts were split into multiple landing-*.spec.ts files.

});
const resJson = await res.json();
if (resJson.length) {
try {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle unexpected errors and increase waiting time for retrieving the verification code from restmail.

@flozia flozia merged commit 973965f into main Oct 1, 2024
16 checks passed
@flozia flozia deleted the e2e-address-flaky-tests branch October 1, 2024 09:11
Copy link

github-actions bot commented Oct 1, 2024

Cleanup completed - database 'blurts-server-pr-5106' destroyed, cloud run service 'blurts-server-pr-5106' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants