Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNTOR-3640 - Use light mode only #5255

Merged
merged 9 commits into from
Oct 29, 2024
Merged

MNTOR-3640 - Use light mode only #5255

merged 9 commits into from
Oct 29, 2024

Conversation

codemist
Copy link
Collaborator

References:

Jira: MNTOR-
Figma:

Description

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5255-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5255-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5255-mgjlpikfea-uk.a.run.app

@codemist codemist changed the title MNTOR-3640 - Enforce white text of prefers-color-scheme: dark + update and support dark mode for Monitor logo MNTOR-3640 - Enforce white text on prefers-color-scheme: dark + default to background image for header and footer Oct 28, 2024
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5255-mgjlpikfea-uk.a.run.app

1 similar comment
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5255-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5255-mgjlpikfea-uk.a.run.app

@codemist codemist changed the title MNTOR-3640 - Enforce white text on prefers-color-scheme: dark + default to background image for header and footer MNTOR-3640 - Use light only Oct 29, 2024
@codemist codemist changed the title MNTOR-3640 - Use light only MNTOR-3640 - Use light mode only Oct 29, 2024
codemist
codemist commented Oct 29, 2024
View reviewed changes
src/emails/templates/HeaderStyles.tsx
Comment on lines +18 to +19
color-scheme: light only;
supported-color-schemes: light only;
Copy link
Collaborator Author

@codemist codemist Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using light only here so for clients that support prefers-color-scheme it should be strictly showing the light mode view, even on dark mode (e.g. iOS/Apple mail)

Clients that don't support it would still invert colours.

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5255-mgjlpikfea-uk.a.run.app

@codemist codemist requested a review from Vinnl October 29, 2024 14:10
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5255-mgjlpikfea-uk.a.run.app

Vinnl
Vinnl approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hopeful that this might be good... Maybe good to call out for QA in advance that seeing the light version is expected - things being readable is the most important thing, I imagine.

@codemist codemist merged commit 2ffbf2a into main Oct 29, 2024
16 checks passed
@codemist codemist deleted the dark-mode-ios branch October 29, 2024 14:23
@github-actions GitHub Actions
Copy link

Cleanup completed - database 'blurts-server-pr-5255' destroyed, cloud run service 'blurts-server-pr-5255' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vinnl Vinnl Vinnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codemist @Vinnl