Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always output the coverage report #5256

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Always output the coverage report #5256

merged 2 commits into from
Oct 30, 2024

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Oct 28, 2024

I intended to do this in 647e95e (#5155), but the failure() call that I remove didn't limit it to failures — it explicitly enabled it for failing jobs, where the default is to skip subsequent jobs after a failure. However, if we want a job to run after both failed and successful runs, we need the always() call.

I intended to do this in 647e95e,
but the `failure()` call that I remove didn't limit it to failures
— it explicitly enabled it for failing jobs, where the default is
to skip subsequent jobs after a failure. However, if we want a job
to run after both failed and successful runs, we need the
`always()` call.
@Vinnl Vinnl added the Review: µ Code review time: 5 minutes or less label Oct 28, 2024
@Vinnl Vinnl requested a review from rhelmer October 28, 2024 16:10
@Vinnl Vinnl self-assigned this Oct 28, 2024
Copy link

Copy link

@Vinnl Vinnl merged commit 08ad1b4 into main Oct 30, 2024
16 checks passed
@Vinnl Vinnl deleted the always-coverage branch October 30, 2024 16:19
Copy link

Cleanup completed - database 'blurts-server-pr-5256' destroyed, cloud run service 'blurts-server-pr-5256' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants