Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNTOR-3494: Upload Sentry source maps by default #5258

Merged
merged 2 commits into from
Oct 30, 2024
Merged

MNTOR-3494: Upload Sentry source maps by default #5258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
992a76c
Upload Sentry source maps by default
Vinnl Oct 29, 2024
2b6cc39
Merge branch 'main' into upload-source-maps-by-default
Vinnl Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ const sentryOptions = {
hideSourceMaps: false,

sourcemaps: {
disable: process.env.UPLOAD_SENTRY_SOURCEMAPS !== "true",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, IIRC it will log a warning saying what you need to do (e.g. set the token) but should not break the build.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, for people who don't have the token, having it on by default will log the error, that makes sense. But agreed that that's no biggie. If we really want to disable the warning, we can also just trigger disable based on whether the token is available - but I think it'd be good to have the warning in our CI logs if something goes wrong with the env var.

disable: process.env.UPLOAD_SENTRY_SOURCEMAPS === "false",
},
};

Expand Down
Loading