Close the SMTP connection pool when done #5260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-5260-mgjlpikfea-uk.a.run.app |
rhelmer
approved these changes
Oct 30, 2024
Vinnl
force-pushed
the
MNTOR-3606-hanging-cronjobs
branch
from
9039130
to
49c86be
Compare
|
Preview URL 🚀 : https://blurts-server-pr-5260-mgjlpikfea-uk.a.run.app |
|
Cleanup completed - database 'blurts-server-pr-5260' destroyed, cloud run service 'blurts-server-pr-5260' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3606
This closes the SMTP pool at the end of the cron job. Together with #5257 and #5254, this at least makes the cron job terminate immediately once it finishes locally for me, and hopefully on stage as well.