Fix repeat loading of erroneous favicons. Fixes #212 (#219)

mozilla · Oct 4, 2017 · 6c43a7c · 6c43a7c
1 parent 23282ad
commit 6c43a7c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/images/defaultFavicon.svg b/src/images/defaultFavicon.svg
diff --git a/src/js/viz.js b/src/js/viz.js
@@ -23,6 +23,7 @@ const viz = {
     this.collisionRadius = this.collisionRadius * this.scalingFactor;
     this.scale = (window.devicePixelRatio || 1) * this.scalingFactor;
     this.transform = d3.zoomIdentity;
+    this.defaultIcon = this.convertURIToImageData('images/defaultFavicon.svg');
 
     this.updateCanvas(width, height);
     this.draw(nodes, links);
@@ -204,6 +205,9 @@ const viz = {
         context.drawImage(image, 0, 0, canvas.width, canvas.height);
         return resolve(context.getImageData(0, 0, canvas.width, canvas.height));
       };
+      image.onerror = () => {
+        return resolve(this.defaultIcon);
+      };
       image.src = URI;
     });
   },

diff --git a/src/manifest.json b/src/manifest.json
@@ -1,7 +1,7 @@
 {
   "manifest_version": 2,
   "name": "Firefox Lightbeam",
-  "version": "2.0.2",
+  "version": "2.0.3",
 
   "description": "Firefox Lightbeam is a Firefox browser extension that uses interactive visualizations to show you the relationships between third parties and the sites you visit.",
   "homepage_url": "https://github.com/mozilla/lightbeam-we",