Skip to content

Commit

Permalink
Reapply "perf(transport): remove Server::timers (#1784)" (#1800) (#1902)
Browse files Browse the repository at this point in the history
This reverts commit 342e4e7.

With #1878 merged and
https://bugzilla.mozilla.org/show_bug.cgi?id=1895319 available, one can now
reapply the patch removing `Server::timers`.

More specifically, the actual bug fix on mozilla-central side:

``` rust
let output = if self.response_to_send.is_empty() {
    output
} else {
    // In case there are pending responses to send, make sure a reasonable
    // callback is returned.
    const MIN_INTERVAL: Duration = Duration::from_millis(100);

    match output {
        Output::None => Output::Callback(MIN_INTERVAL),
        o @ Output::Datagram(_) => o,
        Output::Callback(d) => Output::Callback(min(d, MIN_INTERVAL)),
    }
};
```

See https://phabricator.services.mozilla.com/D209574.
  • Loading branch information
mxinden authored May 15, 2024
1 parent e44c472 commit aebc9ca
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 510 deletions.
4 changes: 0 additions & 4 deletions neqo-common/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,3 @@ features = ["timeapi"]
[lib]
# See https://github.com/bheisler/criterion.rs/blob/master/book/src/faq.md#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options
bench = false

[[bench]]
name = "timer"
harness = false
39 changes: 0 additions & 39 deletions neqo-common/benches/timer.rs

This file was deleted.

1 change: 0 additions & 1 deletion neqo-common/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ pub mod hrtime;
mod incrdecoder;
pub mod log;
pub mod qlog;
pub mod timer;
pub mod tos;

use std::fmt::Write;
Expand Down
Loading

0 comments on commit aebc9ca

Please sign in to comment.