build(deps): update env_logger requirement from 0.10 to 0.11 #2036
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Firefox builds for this PRThe following builds are available for testing. Crossed-out builds did not succeed.
|
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 28f60bd. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.299 ns 99.617 ns 99.937 ns]
change: [-0.6579% -0.0450% +0.4696%] (p = 0.89 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.23 ns 117.63 ns 118.06 ns]
change: [-0.3277% +0.1069% +0.5321%] (p = 0.64 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.74 ns 117.18 ns 117.73 ns]
change: [-0.6087% +0.0349% +0.6312%] (p = 0.91 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.671 ns 97.976 ns 98.366 ns]
change: [-0.7768% +0.0861% +0.9370%] (p = 0.85 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.47 ms 111.63 ms 111.89 ms]
change: [-0.6790% -0.5194% -0.2982%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.414 ms 27.366 ms 28.336 ms]
change: [-6.1101% -1.0412% +4.4266%] (p = 0.70 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.034 ms 36.644 ms 38.238 ms]
change: [-9.4597% -4.0955% +2.0868%] (p = 0.19 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [31.105 ms 31.868 ms 32.611 ms]
change: [-7.1092% -4.4238% -1.3684%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [43.095 ms 46.123 ms 49.137 ms]
change: [-5.8281% +3.3435% +13.011%] (p = 0.48 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [114.04 ms 114.39 ms 114.74 ms]
thrpt: [871.56 MiB/s 874.20 MiB/s 876.91 MiB/s]
change:
time: [-1.4291% -0.9010% -0.3621%] (p = 0.00 < 0.05)
thrpt: [+0.3634% +0.9092% +1.4498%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [313.78 ms 317.56 ms 321.29 ms]
thrpt: [31.124 Kelem/s 31.490 Kelem/s 31.869 Kelem/s]
change:
time: [-2.4778% -1.0508% +0.5281%] (p = 0.19 > 0.05)
thrpt: [-0.5254% +1.0620% +2.5407%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [32.519 ms 32.695 ms 32.883 ms]
thrpt: [30.411 elem/s 30.585 elem/s 30.751 elem/s]
change:
time: [-0.0348% +0.5840% +1.2531%] (p = 0.10 > 0.05)
thrpt: [-1.2376% -0.5806% +0.0348%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Breaking change 0.10 -> 0.11 should not affect neqo.
That said, Firefox build is failing. It complains about multiple env-logger versions in the depedency tree, recommending to upgrade the existing before introducing yet another version:
0:01.12 E There are 2 different versions of crate env_logger (expected 1). Please avoid the extra duplication or adjust TOLERATED_DUPES in python/mozbuild/mozbuild/vendor/vendor_rust.py if not possible (but we'd prefer the former).
https://searchfox.org/mozilla-central/search?q=env_logger+%3D&path=&case=true®exp=false
I don't think this is urgent. Thus I am fine waiting. I can also try to push the other users to the new versions if folks would prefer that.
|
Gecko is still at 0.10.0: https://searchfox.org/mozilla-central/source/Cargo.lock#1684 |
dependabot
bot
force-pushed
the
dependabot/cargo/env_logger-0.11
branch
from
29bbc2a
to
de61982
Compare
dependabot
bot
force-pushed
the
dependabot/cargo/env_logger-0.11
branch
from
de61982
to
3aee5ab
Compare
dependabot
bot
force-pushed
the
dependabot/cargo/env_logger-0.11
branch
from
3aee5ab
to
5007101
Compare
Updates the requirements on [env_logger](https://github.com/rust-cli/env_logger) to permit the latest version. - [Release notes](https://github.com/rust-cli/env_logger/releases) - [Changelog](https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md) - [Commits](rust-cli/env_logger@v0.10.0...v0.11.5) --- updated-dependencies: - dependency-name: env_logger dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/cargo/env_logger-0.11
branch
from
5007101
to
6fc4a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on env_logger to permit the latest version.
Release notes
Sourced from env_logger's releases.
Changelog
Sourced from env_logger's changelog.
... (truncated)
Commits
73bb418chore: Release57f1bb7chore: Releaseba2748fchore: Release4dd976bMerge pull request #324 from Maximkaaa/try_parse05aacb9feat: Add Builder::try_parse methodfaf5b3echore: Tests forparse_specerror messagesc42511crefactor: Return errors fromparse_spec0e25d9echore(deps): Update Rust Stable to v1.79 (#322)e1640c4Merge pull request #320 from epage/templatef8acfeechore: Update from _rust/main templateYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)