Skip to content

Commit

Permalink
Don't add the grey outline when hovering a selected highlight
Browse files Browse the repository at this point in the history
When playing with a pen, I noticed that sometimes a free highlight has still its
gray outline when an other one is drawn: for any reason the pointerleave event isn't
triggered.
  • Loading branch information
calixteman committed Oct 10, 2024
1 parent 233ac17 commit fa7df01
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
8 changes: 0 additions & 8 deletions src/display/editor/annotation_editor_layer.js
Original file line number Diff line number Diff line change
Expand Up @@ -734,14 +734,6 @@ class AnnotationEditorLayer {
this.#uiManager.toggleSelected(editor);
}

/**
* Check if the editor is selected.
* @param {AnnotationEditor} editor
*/
isSelected(editor) {
return this.#uiManager.isSelected(editor);
}

/**
* Unselect an editor.
* @param {AnnotationEditor} editor
Expand Down
6 changes: 5 additions & 1 deletion src/display/editor/editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -1109,6 +1109,10 @@ class AnnotationEditor {
this.#selectOnPointerEvent(event);
}

get isSelected() {
return this._uiManager.isSelected(this);
}

#selectOnPointerEvent(event) {
const { isMac } = FeatureTest.platform;
if (
Expand All @@ -1123,7 +1127,7 @@ class AnnotationEditor {
}

#setUpDragSession(event) {
const isSelected = this._uiManager.isSelected(this);
const { isSelected } = this;
this._uiManager.setUpDragSession();

const ac = new AbortController();
Expand Down
8 changes: 6 additions & 2 deletions src/display/editor/highlight.js
Original file line number Diff line number Diff line change
Expand Up @@ -596,11 +596,15 @@ class HighlightEditor extends AnnotationEditor {
}

pointerover() {
this.parent.drawLayer.addClass(this.#outlineId, "hovered");
if (!this.isSelected) {
this.parent.drawLayer.addClass(this.#outlineId, "hovered");
}
}

pointerleave() {
this.parent.drawLayer.removeClass(this.#outlineId, "hovered");
if (!this.isSelected) {
this.parent.drawLayer.removeClass(this.#outlineId, "hovered");
}
}

#keydown(event) {
Expand Down

0 comments on commit fa7df01

Please sign in to comment.