Improve the implementation of the PDFDocument.fingerprints
-getter
#17862
+48
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit
length
validation of the /ID entries. Given theEMPTY_FINGERPRINT
constant we're already implicitly assuming a particular length.Move the constants into the
fingerprints
-getter, since they're not used anywhere else.Replace the
hexString
helper function with the standardUint8Array.prototype.toHex
method; see https://github.com/tc39/proposal-arraybuffer-base64