Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo:XFATemplate class Para Styling paddingight => paddingRight #18819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bomberus
Copy link

No description provided.

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Copy link
Collaborator

Nit: This should probably have a better commit message than just Fixed Typo since that's pretty non-descriptive!?

@calixteman
Copy link
Contributor

Nit: This should probably have a better commit message than just Fixed Typo since that's pretty non-descriptive!?

Sorry about that: I just focused on the patch itself. @Bomberus ^^

@Bomberus Bomberus changed the title Fixed Typo Fix Typo:XFATemplate class Para Styling paddingight => paddingRight Oct 4, 2024
@Bomberus
Copy link
Author

Bomberus commented Oct 4, 2024

Hi @calixteman,
commit message and title should now be more descriptive.

@Snuffleupagus
Copy link
Collaborator

/botio xfatest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/275a802d8bad8a3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/91a5e401720bb9b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/275a802d8bad8a3/output.txt

Total script time: 15.55 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 44

Image differences available at: http://54.241.84.105:8877/275a802d8bad8a3/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/91a5e401720bb9b/output.txt

Total script time: 27.16 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 23

Image differences available at: http://54.193.163.58:8877/91a5e401720bb9b/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

Looking at the ref-tests there appears to be some actual regressions, e.g. in xfa_bug1718670_1-page3 and xfa_bug1717668_4-page12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants