Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the empty lines in the text fields #18853

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Keep the empty lines in the text fields #18853

merged 1 commit into from
Oct 5, 2024

Conversation

calixteman
Copy link
Contributor

It fixes #18036.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/309ebca2354b240/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/22ee8b9c99bcae8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/309ebca2354b240/output.txt

Total script time: 31.40 mins

  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 21

Image differences available at: http://54.241.84.105:8877/309ebca2354b240/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/22ee8b9c99bcae8/output.txt

Total script time: 47.10 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 10

Image differences available at: http://54.193.163.58:8877/22ee8b9c99bcae8/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a1e1081b3ac62bc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9a3ea9518389d74/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9a3ea9518389d74/output.txt

Total script time: 31.70 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 21
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/9a3ea9518389d74/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a1e1081b3ac62bc/output.txt

Total script time: 47.14 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/a1e1081b3ac62bc/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

Does this PR also fix issue #18130, since that one looks similar?

@calixteman
Copy link
Contributor Author

Does this PR also fix issue #18130, since that one looks similar?

Yep it's the same underlying issue.

@calixteman calixteman force-pushed the issue18036 branch 2 times, most recently from 7dda9c7 to ada7905 Compare October 5, 2024 13:40
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dbadf0fafa43345/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/618a21c2b2edc82/output.txt

@timvandermeij timvandermeij linked an issue Oct 5, 2024 that may be closed by this pull request
lieading linebreaks are not preserved in annotations #18130
Closed
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/dbadf0fafa43345/output.txt

Total script time: 31.63 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 21

Image differences available at: http://54.241.84.105:8877/dbadf0fafa43345/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with comments; thank you.

src/core/annotation.js Outdated Show resolved Hide resolved
src/core/annotation.js Outdated Show resolved Hide resolved
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/618a21c2b2edc82/output.txt

Total script time: 47.31 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 7

Image differences available at: http://54.193.163.58:8877/618a21c2b2edc82/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 5a25c47 into mozilla:master Oct 5, 2024
8 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/02a917583a18901/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bcba8f4807c9779/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/bcba8f4807c9779/output.txt

Total script time: 20.56 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/02a917583a18901/output.txt

Total script time: 26.01 mins

  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij mentioned this pull request Oct 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lieading linebreaks are not preserved in annotations Extra line breaks are missing when PDF is loaded
4 participants
@calixteman @moz-tools-bot @Snuffleupagus @timvandermeij