Re-factor the MessageHandler-class event handler function
#18888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
MessageHandler-AbortSignal
branch
from
5a0e310
to
71b98df
Compare
- Change the "message" event handler function to a private method. - Remove the "message" event listener with an `AbortSignal`. - Extend the `LoopbackPort`-class with `AbortSignal` support.
Snuffleupagus
force-pushed
the
MessageHandler-AbortSignal
branch
from
71b98df
to
788eabc
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/caffd6e4756ebab/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8227d4eef18b891/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/caffd6e4756ebab/output.txt Total script time: 31.45 mins
Image differences available at: http://54.241.84.105:8877/caffd6e4756ebab/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8227d4eef18b891/output.txt Total script time: 53.39 mins
Image differences available at: http://54.193.163.58:8877/8227d4eef18b891/reftest-analyzer.html#web=eq.log |
nicolo-ribaudo
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the "message" event handler function to a private method.
Remove the "message" event listener with an
AbortSignal.Extend the
LoopbackPort-class withAbortSignalsupport.Smaller diff with https://github.com/mozilla/pdf.js/pull/18888/files?w=1