Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation deletion popup (bug 1899731) #18900

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Annotation deletion popup (bug 1899731) #18900

wants to merge 9 commits into from
+1,009 −93

Commits on Oct 21, 2024

  1. Break messageBar class out 

    Move .messageBar out of .dialog into its own standalone class in order to reuse as much of it for the upcoming feature for an undo message for annotations.
    @ryzokuken
    ryzokuken committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b107fff View commit details
    Browse the repository at this point in the history

  2. Pop open a message when user deletes an annotation 

    When a user deletes any number of annotations, they are notified of the action
by a popup message with an undo button. Besides that, this change reuses the
existing messageBar CSS class from the new alt-text dialog as much as possible.
    @ryzokuken
    ryzokuken committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    291b593 View commit details
    Browse the repository at this point in the history

  3. fixup! Pop open a message when user deletes an annotation 

    Fix colors in dark and high contrast modes
    @nicolo-ribaudo @ryzokuken
    nicolo-ribaudo authored and ryzokuken committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d26ab1f View commit details
    Browse the repository at this point in the history

  4. fixup! Pop open a message when user deletes an annotation 

    Fix l10n
    @nicolo-ribaudo @ryzokuken
    nicolo-ribaudo authored and ryzokuken committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    95c8b8c View commit details
    Browse the repository at this point in the history

  5. fixup! Pop open a message when user deletes an annotation

    @ryzokuken
    ryzokuken committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    26a5fd8 View commit details
    Browse the repository at this point in the history

  6. Add tests for annotation delete popup

    @Aditi-1400 @ryzokuken
    Aditi-1400 authored and ryzokuken committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5ec02a6 View commit details
    Browse the repository at this point in the history

  7. fixup! Pop open a message when user deletes an annotation

    @ryzokuken
    ryzokuken committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a3d26c3 View commit details
    Browse the repository at this point in the history

  8. fixup! Add tests for annotation delete popup

    @ryzokuken
    ryzokuken committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a893637 View commit details
    Browse the repository at this point in the history

  9. fixup! Pop open a message when user deletes an annotation

    @ryzokuken
    ryzokuken committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c1cbf9b View commit details
    Browse the repository at this point in the history