Fix the "Text selection using mouse doesn't jump when hovering on an empty area in a single page" integration test #18923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ce5b434f00d4001/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/acc10694e51dd8f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ce5b434f00d4001/output.txt Total script time: 9.21 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/acc10694e51dd8f/output.txt Total script time: 20.23 mins
|
timvandermeij
force-pushed
the
integration-test-text-layer
branch
from
e743e0f
to
cb37d8a
Compare
…empty area in a single page" integration test The `getSpanRectFromText` helper function returns the location as float values. This could be desirable in cases where the exact values matter (for example during comparisons), but in the text layer tests we don't need this precision. Moreover, the Puppeteer `page.mouse.move` API apparently doesn't work correctly if float values are given as input. Note that this test only failed because it couldn't move to the initial selection position; any subsequent moves actually worked because the `moveInSteps` helper function already rounded all values correctly. This commit fixes the issue by consistently rounding all values that we pass to Puppeteer's `page.mouse.move` API.
timvandermeij
force-pushed
the
integration-test-text-layer
branch
from
cb37d8a
to
24b8393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getSpanRectFromTexthelper function returns the location as float values. This could be desirable in cases where the exact values matter (for example during comparisons), but in the text layer tests we don't need this precision. Moreover, the Puppeteerpage.mouse.moveAPI apparently doesn't work correctly if float values are given as input.Note that this test only failed because it couldn't move to the initial selection position; any subsequent moves actually worked because the
moveInStepshelper function already rounded all values correctly.This commit fixes the issue by consistently rounding all values that we pass to Puppeteer's
page.mouse.moveAPI.Fixes #18774.