Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the eslint-plugin-{fetch-options,html} and eslint-config-prettier dependencies #18927

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

timvandermeij
Copy link
Contributor

The commit messages contains more details about the individual changes.

Fixes a part of #17928.

The plugins have originally been introduced in commit d63da81 for the
`eslint-plugin-mozilla` dependency, but the `eslint-plugin-mozilla`
plugin got removed in commit be93d53 and we also don't use the plugins
ourselves in e.g. our `.eslintrc` files (as evidenced by `npx gulp lint`
not failing while it does fail if we remove any of the other plugins).
The `eslint-plugin-prettier` dependency already installs this dependency
by default nowadays, so we don't have to specify it ourselves anymore.
@Snuffleupagus

This comment was marked as outdated.

@mozilla mozilla deleted a comment from moz-tools-bot Oct 20, 2024
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, fewer direct dependencies never hurt; thank you.

@timvandermeij timvandermeij merged commit 29b2f26 into mozilla:master Oct 20, 2024
8 checks passed
@timvandermeij timvandermeij deleted the eslint-plugin-cleanup branch October 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants