Re-enable spellchecker in translation editor #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
approved these changes
Jun 21, 2023
| @@ -66,6 +66,7 @@ export const EditField = memo( | |||
| setResultFromInput(index, update.state.doc.toString()); | |||
| } | |||
| }), | |||
| EditorView.contentAttributes.of({ spellcheck: 'true' }), | |||
There was a problem hiding this comment.
This should be set in getExtensions() rather than here, as it's not dependent on any of the EditField state. But presuming that you've tested this to work as intended, this should be the right fix.
There was a problem hiding this comment.
I thought this would also trigger the spellcheck in the read-only mode. But it doesn't, so let's move it.
Closed
mathjazz
added a commit
to mathjazz/pontoon
that referenced
this pull request
Jun 22, 2023
This reverts commit efa6859.
eemeli
pushed a commit
to eemeli/pontoon
that referenced
this pull request
Jul 25, 2023
eemeli
added a commit
that referenced
this pull request
Jul 26, 2023
…itor results have updated (#2917) * Replace editor `<textarea>` with CodeMirror v6 * refactor: Add EditFieldHandle and EditorResult as interfaces for the editor value * Add syntax highlighting for placeholders and tags * Re-enable spellchecker in translation editor (#2884) * Delay setting failed checks until editor results have updated * Update tests to account for setTimeout * Scroll editor settings menu into view on display --------- Co-authored-by: Matjaž Horvat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2881.
(Currently deployed to stage.)