-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pretranslation Monitoring spec #2904
Add Pretranslation Monitoring spec #2904
Conversation
|
||
A new "Pretranslation quality" chart is made available at the bottom of the (Team, Project and Project-Locale) Insights pages, presenting data for the period of the last 12 months. It is a combination of three charts: | ||
|
||
1. A column chart showing pretranslation review actions over time in a stack of two columns - approvals and rejections of pretranslations. Approvals and rejections performed by sync are excluded. New pretranslations are plotted in a separate column, which is hidden by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the hidden column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it doesn't have impact on the quality metrics (approval ratio and chrF++ score).
It's also consistent with New suggestions and New source strings in the Review/Translation activity panels.
Can you expand on this? KR 1.1 is about community metrics collection, which shouldn't involve dashboards? Also, only the review part would probably be part of that.
I was thinking that you can't go through 50+ locales to check if there are issues: you would check the main dashboard, then switch to single locale or project dashboards to look at data in more detail. For example:
The question is if these two charts are going to get too crowded. Also, given I expect this type of question to get asked:
That information wouldn't be easily accessible to all PMs, especially the latter. |
As discussed at the team call last week, let's drop this idea.
I'll update the spec with the new
I'll also add "average" to each chart, which will represent the global approval rate across all locales and projects. If these charts turn out to be unusable during the implementation phase, we can create tabular views, simiar to |
35b855f
to
72c36d6
Compare
72c36d6
to
c2b6783
Compare
I haven't added the mockup for the /insights page. It's quite obvious how it would look like, and I'd rather not spend time working on the design, before figuring out if it even works with the real data. So I'd prefer to go straight to implementation, revisit the design decision and update the spec accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Co-authored-by: Francesco Lodolo <[email protected]>
Fix #2894.
A couple of differences from what we discussed at the meeting:
TODO: I need to make another pass at the colors, but that's not blocking the review.