Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pretranslation Monitoring spec #2904

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

mathjazz
Copy link
Collaborator

@mathjazz mathjazz commented Jul 5, 2023

Fix #2894.

A couple of differences from what we discussed at the meeting:

  • There is no breakdown of data per project on the Team dashboard and no breakdown of data per team on the Project dashboard.
    • Instead, we plot the Pretranslation review activity chart also on the Project-Locale dashboard.
    • Also, (separately from this feature) we could add data filters to all Insights panels.
  • No "One dashboard" with the overall data on pretranslation (Pontoon-level oversight).
    • Instead, I'd like to approach this more holistically as part of KR 1.1.
    • Also, what do we need this information for? Would it be enough to expose numbers over the API (or gather them via a script)?

TODO: I need to make another pass at the colors, but that's not blocking the review.

@mathjazz mathjazz requested a review from flodolo July 5, 2023 18:16
specs/0114-pretranslation-monitoring.md Outdated Show resolved Hide resolved
specs/0114-pretranslation-monitoring.md Outdated Show resolved Hide resolved

A new "Pretranslation quality" chart is made available at the bottom of the (Team, Project and Project-Locale) Insights pages, presenting data for the period of the last 12 months. It is a combination of three charts:

1. A column chart showing pretranslation review actions over time in a stack of two columns - approvals and rejections of pretranslations. Approvals and rejections performed by sync are excluded. New pretranslations are plotted in a separate column, which is hidden by default.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the hidden column?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it doesn't have impact on the quality metrics (approval ratio and chrF++ score).

It's also consistent with New suggestions and New source strings in the Review/Translation activity panels.

@flodolo
Copy link
Collaborator

flodolo commented Jul 6, 2023

No "One dashboard" with the overall data on pretranslation (Pontoon-level oversight).
Instead, I'd like to approach this more holistically as part of KR 1.1.

Can you expand on this? KR 1.1 is about community metrics collection, which shouldn't involve dashboards? Also, only the review part would probably be part of that.

Also, what do we need this information for?

I was thinking that you can't go through 50+ locales to check if there are issues: you would check the main dashboard, then switch to single locale or project dashboards to look at data in more detail. For example:

  • One graph with average approval rate over time per locale (line chart, one line per locale).
  • Same graph, but per project.

The question is if these two charts are going to get too crowded.

Also, given I expect this type of question to get asked:

  • Histogram chart over time with number of pretranslated strings and approval rate across all locales and projects.

Would it be enough to expose numbers over the API (or gather them via a script)?

That information wouldn't be easily accessible to all PMs, especially the latter.

@mathjazz
Copy link
Collaborator Author

mathjazz commented Jul 25, 2023

No "One dashboard" with the overall data on pretranslation (Pontoon-level oversight).
Instead, I'd like to approach this more holistically as part of KR 1.1.

Can you expand on this? KR 1.1 is about community metrics collection, which shouldn't involve dashboards? Also, only the review part would probably be part of that.

As discussed at the team call last week, let's drop this idea.

Also, what do we need this information for?

I was thinking that you can't go through 50+ locales to check if there are issues: you would check the main dashboard, then switch to single locale or project dashboards to look at data in more detail. For example:

* One graph with average approval rate over time per locale (line chart, one line per locale).

* Same graph, but per project.

The question is if these two charts are going to get too crowded.

Also, given I expect this type of question to get asked:

* Histogram chart over time with number of pretranslated strings and approval rate across all locales and projects.

I'll update the spec with the new /insights page. It will consist of two graphs mentioned above:

  • one with approval rate over time line for each locale,
  • one with approval rate over time line for each project.

I'll also add "average" to each chart, which will represent the global approval rate across all locales and projects.

If these charts turn out to be unusable during the implementation phase, we can create tabular views, simiar to /teams and /projects, which will show approval rate charts for each locale and project in a separate line.

@mathjazz mathjazz force-pushed the 2894-pretranslation-monitoring-spec branch from 35b855f to 72c36d6 Compare July 25, 2023 10:22
@mathjazz mathjazz force-pushed the 2894-pretranslation-monitoring-spec branch from 72c36d6 to c2b6783 Compare July 25, 2023 10:25
@mathjazz
Copy link
Collaborator Author

mathjazz commented Jul 25, 2023

I haven't added the mockup for the /insights page. It's quite obvious how it would look like, and I'd rather not spend time working on the design, before figuring out if it even works with the real data. So I'd prefer to go straight to implementation, revisit the design decision and update the spec accordingly.

@mathjazz mathjazz requested a review from flodolo July 25, 2023 10:29
Copy link
Collaborator

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

specs/0115-pretranslation-monitoring.md Outdated Show resolved Hide resolved
Co-authored-by: Francesco Lodolo <[email protected]>
@mathjazz mathjazz merged commit 22da53e into mozilla:master Jul 25, 2023
@mathjazz mathjazz deleted the 2894-pretranslation-monitoring-spec branch July 25, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretranslation: write spec for continuous monitoring
2 participants