Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove format option in Newsletter form #928

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

reemhamz
Copy link
Contributor

@reemhamz reemhamz commented Apr 3, 2024

Description

The email marketing team have asked to remove the format option in the Newsletter component, as text based email are not supported by Braze (our new vendor).

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Issue

#926

Testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting some squigglies in this file to fix spacing so I fixed that up

@reemhamz reemhamz added Review: XS Code review time: 30 mins or less Needs:Review 👋 Ready for Developer Review labels Apr 3, 2024
@reemhamz reemhamz requested a review from craigcook April 4, 2024 04:35
@craigcook craigcook self-assigned this Apr 4, 2024
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👔

@craigcook craigcook merged commit 99d36e4 into main Apr 4, 2024
2 checks passed
@craigcook craigcook deleted the remove-newsletter-format branch April 4, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs:Review 👋 Ready for Developer Review Review: XS Code review time: 30 mins or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants