Upgrade build system to support a minimum of Java 11 only

.github/workflows/gradle.yml

@@ -15,7 +15,7 @@ jobs:
       # Some tests require more CPU, and all can use multiple CPUs
       max-parallel: 1
       matrix:
-        java: [ '8', '11', '17' ]
+        java: [ '11', '17' ]
     name: Rhino Java ${{ matrix.java }}
     steps:
     - name: Checkout
@@ -31,11 +31,7 @@ jobs:
       with:
         java-version: ${{ matrix.java }}
         distribution: 'adopt'
-    - if: matrix.java == '8'
-      name: Check everything with Gradle on Java 8
-      run: ./gradlew check jacocoTestReport
-    - if: matrix.java != '8'
-      name: Check everything with Gradle, modular Java
+    - name: Check everything with Gradle
       run: >-
         ./gradlew check jacocoTestReport
         -Dorg.gradle.jvmargs="--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED

build.gradle

@@ -7,13 +7,13 @@ plugins {
     id 'jacoco'
     id 'distribution'
     id 'checkstyle'
-    id 'com.diffplug.spotless' version "5.12.1"
+    id 'com.diffplug.spotless' version "5.13.0"
     id 'com.github.spotbugs' version "4.7.1"
 }
 
 tasks.withType(JavaCompile) {
-    sourceCompatibility = 1.8
-    targetCompatibility = 1.8
+    sourceCompatibility = 11
+    targetCompatibility = 11
     options.encoding = "UTF-8"
     options.compilerArgs = [ "-Xlint:deprecation,unchecked" ]
 }
@@ -71,10 +71,8 @@ test {
     exclude "**/benchmarks/**"
 
     jvmArgs += '-Xss1280k'
-
-    if (JavaVersion.current() > JavaVersion.VERSION_1_8) {
-        jvmArgs += ['--add-opens', 'java.desktop/javax.swing.table=ALL-UNNAMED']
-    }
+    jvmArgs += ['--add-opens', 'java.base/java.util=ALL-UNNAMED']
+    jvmArgs += ['--add-opens', 'java.desktop/javax.swing.table=ALL-UNNAMED']
 
     jacoco.excludes = ['**/testsrc_tests_ecma_3_RegExp_perlstress*']
 
@@ -441,6 +439,16 @@ spotbugs {
     excludeFilter = file("./spotbugs-exclude.xml")
 }
 
+spotbugsMain {
+    reports {
+        html {
+            required = true
+            outputLocation = file("$buildDir/reports/spotbugs/main/spotbugs.html")
+            stylesheet = 'fancy-hist.xsl'
+        }
+    }
+}
+
 spotless {
     java {
         googleJavaFormat().aosp()

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

spotbugs-exclude.xml

@@ -109,6 +109,11 @@
     <Class name="org.mozilla.javascript.optimizer.OptRuntime$GeneratorState"/>
     <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
   </Match>
+  <Match>
+    <!-- Really old legacy stuff -->
+    <Class name="org.mozilla.javascript.ContextFactory$1GlobalSetterImpl"/>
+    <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+  </Match>
   <!-- Complex legacy stuff -->
   <!--<Match>
     <Class name="org.mozilla.javascript.regexp.RegExpImpl"/>