Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions introduced to debugger #1369

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

gbrail
Copy link
Collaborator

@gbrail gbrail commented Aug 11, 2023

This PR consolidates a change made by @jonasPoehler with additional changes to fix debugger regressions introduced earlier.

Could regular users of the debugger please try it out? Some obviously-broken functionality seems to be working again compared
to previous releases but there may be more to test.

jonasPoehler and others added 2 commits August 10, 2023 18:44
Correctly identify the button being pressed using non-deprecated
functions to fix regression introduced earlier.
@gbrail
Copy link
Collaborator Author

gbrail commented Aug 11, 2023

This includes fixes originally contributed to #1367

@jonasPoehler
Copy link
Contributor

Hey @gbrail, thank you for looking into this. I did checkout your branch and did some quick testing and poking around. I can confirm, that the breakpoint-fix still works and I didn't find any other obvious problem. However I wouldn't know where to look for in the context of the isCellEditable method, so there is the potential for some bug lurking, but you get that all the time with manual testing.

@gbrail
Copy link
Collaborator Author

gbrail commented Aug 15, 2023

Thanks -- I think I know what that other method does and it seems to be working. I'm going to merge this. Thanks for checking it out!

@gbrail gbrail merged commit da1fcbb into mozilla:master Aug 15, 2023
3 checks passed
@gbrail gbrail deleted the breakpoint branch August 15, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants