Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation of Reflect & Proxy support #1431

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

implementation of Reflect & Proxy support #1431

wants to merge 31 commits into from

Commits on Nov 10, 2023

  1. first implementation of NativeReflect

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    32c76f9 View commit details
    Browse the repository at this point in the history

  2. fix broken backward compatibility (use the same approach as for all t… 

    …he other symbol based methods)
    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    2af111f View commit details
    Browse the repository at this point in the history

  3. fix typos

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    6f2e843 View commit details
    Browse the repository at this point in the history

  4. working on proxy support (wip)

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    a14836c View commit details
    Browse the repository at this point in the history

  5. apply implemented

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    a778d4b View commit details
    Browse the repository at this point in the history

  6. built-ins/Proxy 152/306 (49.67%) 

    milestone I reached
    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    11e7ea1 View commit details
    Browse the repository at this point in the history

  7. built-ins/Proxy 134/306 (43.79%)

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ccb2bda View commit details
    Browse the repository at this point in the history

  8. convert to lambda

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    18f010a View commit details
    Browse the repository at this point in the history

  9. built-ins/Proxy 120/306 (39.22%)

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    bc02187 View commit details
    Browse the repository at this point in the history

  10. built-ins/Proxy 93/306 (30.39%)

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    42f8dfe View commit details
    Browse the repository at this point in the history

  11. getOwnPropertyDescriptor [built-ins/Proxy 88/306 (28.76%) / built-ins… 

    …/Reflect 20/139 (14.39%)]
    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    166f81c View commit details
    Browse the repository at this point in the history

  12. more detailed get trap handling

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    8e0cab8 View commit details
    Browse the repository at this point in the history

  13. NativeProxy has to support revoking from a trap 

    SymbolKeys are shallowEq to symbols
isArray has to take care of proxies
    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    7c16e1b View commit details
    Browse the repository at this point in the history

  14. implement more details for defineProperty 

    fix missing return for put traps
    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    bbd5e5d View commit details
    Browse the repository at this point in the history

  15. construct now supports newTarget

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    c1ff1fd View commit details
    Browse the repository at this point in the history

  16. current status of the impl

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    1d8d99d View commit details
    Browse the repository at this point in the history

  17. spotless

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    9b2993f View commit details
    Browse the repository at this point in the history

  18. remove leftover from lambda migration

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    db5443e View commit details
    Browse the repository at this point in the history

  19. defineOwnProperty() now return a boolean - THIS BREAKS backward compa… 

    …tibility
    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f2caa7c View commit details
    Browse the repository at this point in the history

  20. preventExtensions has to return a boolean (incompatible change)

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    89fa899 View commit details
    Browse the repository at this point in the history

  21. one more get fix

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    cd353f1 View commit details
    Browse the repository at this point in the history

  22. next minor step

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f12c678 View commit details
    Browse the repository at this point in the history

  23. fix handling of primitive values in Reflect.apply (see HtmlUnit/htmlu… 

    …nit#641)
    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    4f4944a View commit details
    Browse the repository at this point in the history

  24. fix rebase

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    976af2c View commit details
    Browse the repository at this point in the history

  25. fix rebase

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    7288d22 View commit details
    Browse the repository at this point in the history

  26. some more test are fixed with the latest rebase

    @rbri
    rbri committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    8518a8f View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. some fixes based on HtmlUnit#9

    @rbri
    rbri committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    70bfa44 View commit details
    Browse the repository at this point in the history

  2. spotless

    @rbri
    rbri committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    144e93c View commit details
    Browse the repository at this point in the history

  3. spotbugs

    @rbri
    rbri committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    2c87299 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2023

  1. add test for ctor args fix

    @rbri
    rbri committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    b51da8c View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. set-callTrap should be called with the value, not the descriptor of v… 

    …alue
    @rbri
    rbri committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    36d7615 View commit details
    Browse the repository at this point in the history