FEAT: Implement ??

[0xe]

Closes #938

[rbri]

@0xe maybe https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR_assignment and https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_AND_assignment are doable in a similar way.... ;-)

[p-bakker]

You'll want to uncomment the language/expressions/coalesce section in test262.properties, so all the tests related to this feature will run

[p-bakker]

@0xe maybe https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR_assignment and https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_AND_assignment are doable in a similar way.... ;-)

While at it, why not toss in the optional chaining operator 🤪 See #936 and #937

[nabacg]

still WIP #1593 but I couldn't help myself to give it a try!

[p-bakker]

Pipeline fails cause not all tests from language/expressions/coalesce pass

[p-bakker]

@rbri I assume you meant ||= and &&= instead of |= and &=, as I think the latter two bitwise operators (which you linked to) are already supported

[andreabergia]

@0xe maybe https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR_assignment and https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_AND_assignment are doable in a similar way.... ;-)

#1597 :)

[0xe]

Pipeline fails cause not all tests from language/expressions/coalesce pass

Thanks, I've fixed the failing test.

[gbrail]

This looks good to me -- any thoughts from anyone else?

One minor question -- the addition of a "NULLISH_COALESCING" token is a name we'll have to live with for a long time. Are we sure that we like that name -- does it match how people talk about this feature elsewhere in the JavaScript world? Or is another name more appropriate.

+1 for adding a French translation, BTW!

[gbrail]

Also, if others are OK then please rebase it so that we can merge it. Thanks!

[0xe]

This looks good to me -- any thoughts from anyone else?

One minor question -- the addition of a "NULLISH_COALESCING" token is a name we'll have to live with for a long time. Are we sure that we like that name -- does it match how people talk about this feature elsewhere in the JavaScript world? Or is another name more appropriate.

+1 for adding a French translation, BTW!

Thanks. We picked NULLISH_COALESCING based on what MDN calls it. Happy to change if another name is more commonly used in the community.

[0xe]

Also, if others are OK then please rebase it so that we can merge it. Thanks!

I've rebased it against master.