Java List and array access improvements #561
Conversation
both NativeJavaArray and NativeJavaList for better compatability with JS. Add a couple of tests for the list and array access.
line ending in the tests.
|
Thanks. I'll take a look at this next week after we finish the 1.7.11 release. One difference between this and other built-in classes is in the way that it adds new methods -- other native classes inherit from IdScriptableObject whereas this one uses a different method. One thing that we might want to do is to make this class work that way too. Also, a number of the prototype classes on regular arrays should work on Java arrays too -- we should look and see why not. |
|
Yeah, I tried to use a couple of ways to implement the JavaScript functions. The thing is, that the wrapped object should expose all the methods and properties from the object implementing the List interface. For example, in our projects we tend to have business objects, which implement List interface, but have quite a lot of other business logic in them too. |
| if (arg instanceof Wrapper) | ||
| arg = ((Wrapper)arg).unwrap(); | ||
|
|
||
| int start = 0; |
There was a problem hiding this comment.
Is there a test when start is specified as an argument?
var a = java.util.Arrays.asList(1, 2, 3).toArray();
a.indexOf(1, 5); // -1?
a.indexOf(1, -5); // throw error?|
|
||
| int length = Array.getLength(array); | ||
| for (int index = start; index < length; index++) | ||
| if (Objects.deepEquals(arg, Array.get(array, index))) |
There was a problem hiding this comment.
Is there a test to make sure deepEquals is called?
p-bakker
added
the
Java Interop
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class AccessingJavaList extends TestCase { |
There was a problem hiding this comment.
This test is passing in the current codebase.
| public Object get(String id, Scriptable start) { | ||
| if (id.equals("length")) | ||
| return Integer.valueOf(list.size()); | ||
| else if (id.equals("includes")) |
There was a problem hiding this comment.
This is only one extension of the list.
I think we were both trying to reach the same goal: See #830
A JavaList should be treated like an Array and provide functions like join, includes etc...
|
Most of the test cases SHOULD¹ pass in the current codebase of #1083. (¹ plugins.gradle.com is currently down...) |
|
Closing this one for lack of activity and the idea behind this PR likely already been solved in other PRs If there's still merit to this PR, please reopen after a rebase |
Add a new wrapper calss NativeJavaList that provides natural JS array access for Java lists. Improve NativeJavaArray for better compatability with JS via the addition of indexOf and includes functions. Add a couple of tests for the list and array access.