Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for an empty / null inputs to Tags by removing that frame #149

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

czipperz
Copy link

@czipperz czipperz commented Aug 9, 2018

No description provided.

@coveralls
Copy link

coveralls commented Aug 9, 2018

Coverage Status

Coverage decreased (-0.5%) to 68.068% when pulling 90f32ad on czipperz:master into c3917e8 on mpatric:master.

@tmzkt
Copy link
Collaborator

tmzkt commented Dec 30, 2018

This change makes setTrack inconsistent with the rest of the setters. Also, the pull request is missing tests for your proposed change.
The clearFrameSet method would provide you the ability to remove the track number. What is the motivation for keeping the frame with a blank string in it?

@czipperz czipperz changed the title Allow for an empty track. Allow for an empty / null inputs to Tags by clearing that frame Apr 10, 2019
@czipperz
Copy link
Author

Honestly when writing my app using this, I found it frustrating that my use case (deleting these specific frames) wasn't supported. Now this allows null or "" (empty string). They remove the frame.

@czipperz czipperz changed the title Allow for an empty / null inputs to Tags by clearing that frame Allow for an empty / null inputs to Tags by removing that frame Apr 10, 2019
@czipperz
Copy link
Author

I don't understand how it thinks I am decreasing coverage. It seems it is counting my tests (which are in a separate file) as source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants