New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constructors for FileDescriptors #172

Open

keyboardr wants to merge 1 commit into mpatric:master from keyboardr:master

keyboardr commented Apr 27, 2020

Adds support for creating Mp3Files with FileDescriptors. Fixes #171

Since FileDescriptors contain less information than Files or Paths, some caveats are needed:

Saving new files from these Mp3Files is not supported since the absolute path cannot be verified.
getFilename() and getLastModified() will throw an exception.
getLength() is only valid after initialization (shouldn't be an issue for those using Mp3File, but it is a concern for FileWrapper).


          Add constructors for FileDescriptors

75e46e0

Collaborator

hennr commented Apr 11, 2022

Thanks for the PR @keyboardr
I am not into android programming, anyone who can offer a review here would be very appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet