forked from openshift/oadp-operator
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add flake attempts to the flaky tests and include known flakes patter…
…n detection This adds attempts to the flaky tests, which are caused by two known issues. First one isn't yet available in the CI cluster, second is known and needs to be fixed in the Velero code: - kubernetes-csi/external-snapshotter#876 - vmware-tanzu/velero#5856 The known flake pattern detection allows us to specify which flakes are the ones on which we will retry. Signed-off-by: Michal Pryc <[email protected]>
- Loading branch information
Showing
5 changed files
with
114 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| package lib | ||
|
|
||
| import ( | ||
| "log" | ||
| "regexp" | ||
| ) | ||
|
|
||
| var errorIgnorePatterns = []string{ | ||
| "received EOF, stopping recv loop", | ||
| "Checking for AWS specific error information", | ||
| "awserr.Error contents", | ||
| "Error creating parent directories for blob-info-cache-v1.boltdb", | ||
| "blob unknown", | ||
| "num errors=0", | ||
| "level=debug", // debug logs may contain the text error about recoverable errors so ignore them | ||
| "Unable to retrieve in-cluster version", | ||
| "restore warning", | ||
|
|
||
| // Ignore managed fields errors per https://github.com/vmware-tanzu/velero/pull/6110 and avoid e2e failure. | ||
| // https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oadp-operator/1126/pull-ci-openshift-oadp-operator-master-4.10-operator-e2e-aws/1690109468546699264#1:build-log.txt%3A686 | ||
| "level=error msg=\"error patch for managed fields ", | ||
| } | ||
|
|
||
| type FlakePattern struct { | ||
| Issue string | ||
| Description string | ||
| StringSearchPattern string | ||
| } | ||
|
|
||
| // CheckIfFlakeOccured checks for known flake patterns in the provided input string (typically log from the test ran). | ||
| // It updates the value pointed to by knownFlake based on whether a known flake pattern is found. | ||
| // | ||
| // Parameters: | ||
| // | ||
| // input (string): The input string to be examined for known flake patterns. | ||
| // knownFlake (*bool): A pointer to a boolean variable that will be updated based on whether a known flake pattern is found in the input. | ||
| func CheckIfFlakeOccured(input string, knownFlake *bool) { | ||
|
|
||
| flakePatterns := []FlakePattern{ | ||
| { | ||
| Issue: "https://github.com/kubernetes-csi/external-snapshotter/pull/876", | ||
| Description: "Race condition in the VolumeSnapshotBeingCreated", | ||
| StringSearchPattern: "Failed to check and update snapshot content: failed to remove VolumeSnapshotBeingCreated annotation on the content snapcontent-", | ||
| }, | ||
| { | ||
| Issue: "https://github.com/vmware-tanzu/velero/issues/5856", | ||
| Description: "Transient S3 bucket errors and limits", | ||
| StringSearchPattern: "Error copying image: writing blob: uploading layer chunked: received unexpected HTTP status: 500 Internal Server Error", | ||
| }, | ||
| } | ||
|
|
||
| for _, pattern := range flakePatterns { | ||
| re := regexp.MustCompile(pattern.StringSearchPattern) | ||
| if re.MatchString(input) { | ||
| log.Printf("FLAKE DETECTION: Match found for issue %s: %s\n", pattern.Issue, pattern.Description) | ||
| *knownFlake = true | ||
| return | ||
| } | ||
| } | ||
| log.Println("FLAKE DETECTION: No known flakes found.") | ||
| *knownFlake = false | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters