-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encode backward and use C stubs #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update code-generation so it writes values backward.
run exactly one encoding per iteration, do better checks
we preallocate the encoder. Actual encoding time is more interesting because in high perf situations we'll reuse allocators.
it's no alloc, so as @Armael pointed out we don't need the CAML*** macros
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rationale: encoding backward means we can use a single buffer even in the presence of nested messages. We encode from the end, in reverse order, which means we encode the sub-message before having to write its size; so when it's time to write the size we know it and we can just write the varint. If we write forward we cannot do that because we don't know how much space to leave in front to encode the length as a varint.
The C stubs are there to make varint operations faster: computing how many bytes a varint takes (so we can allocate a little slice for it in the buffer); and writing the varint into this slice.
Note that we also require OCaml >= 4.08 so we can rely on Bytes' operations for fixed-size bits32/bits64.