New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchedMesh: Fix bug in deleteGeometry #30304

Open

jonathanzopes wants to merge 1 commit into mrdoob:dev from jonathanzopes:fix_batched_mesh_del_geom

+1 −1

jonathanzopes commented Jan 11, 2025

Related forum discussion thread: https://discourse.threejs.org/t/batchedmesh-deleting-instances-and-geometry/76193/1

Description

Verify if instances are still active, before deleting them within deleteGeometry.


          Check if instance active.

d4fbfd2

github-actions bot commented Jan 11, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	339.52 79.1	339.52 79.1	+0 B +0 B
WebGPU	490.8 136.38	490.8 136.38	+0 B +0 B
WebGPU Nodes	490.26 136.27	490.26 136.27	+0 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.41 112.15	465.41 112.15	+0 B +0 B
WebGPU	561.37 152.09	561.37 152.09	+0 B +0 B
WebGPU Nodes	516.76 141.66	516.76 141.66	+0 B +0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet