Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle leak in NtQueryInformationProcess(ProcessDebugObjectHandle) #30

Merged
merged 1 commit into from
Sep 2, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions TitanHide/hooks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,17 @@ static NTSTATUS NTAPI HookNtQueryInformationProcess(
{
BACKUP_RETURNLENGTH();

__try
{
// This was a successful request and a valid handle was returned.
// That means we should close it before we nuke it to prevent handle leaks.
ObCloseHandle(*(PHANDLE)ProcessInformation, KernelMode);
}
__except(EXCEPTION_EXECUTE_HANDLER)
{
NOTHING;
}

*(ULONG_PTR*)ProcessInformation = 0;

RESTORE_RETURNLENGTH();
Expand Down