Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes iterator helpers when interacting with other polyfills #80

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

mhassan1
Copy link
Collaborator

This PR fixes iterator helpers when loaded alongside other polyfills (e.g. String.prototype.@@iterator). It is a follow-up to #76.

@mhassan1 mhassan1 marked this pull request as draft October 21, 2024 19:54
@mhassan1 mhassan1 mentioned this pull request Oct 21, 2024
@mhassan1 mhassan1 marked this pull request as ready for review October 22, 2024 00:18
@mhassan1 mhassan1 requested a review from romainmenke October 22, 2024 00:18
@romainmenke
Copy link
Member

IE is still failing, but might also be a browserstack issue: https://github.com/mrhenry/polyfill-library/actions/runs/11454689367/job/31934817539
I've noticed that IE has more and more intermittent issues on browserstack.

@mhassan1
Copy link
Collaborator Author

IE is still failing, but might also be a browserstack issue: https://github.com/mrhenry/polyfill-library/actions/runs/11454689367/job/31934817539 I've noticed that IE has more and more intermittent issues on browserstack.

I can replicate that issue locally. When I look in BrowserStack, I see Browser could not be launched for the session. Here are some docs about that: https://www.browserstack.com/docs/automate/selenium/error-codes/browserstack-failed-to-start-browser. Maybe we should open a support ticket.

Any comments on this PR?

@mhassan1
Copy link
Collaborator Author

mhassan1 commented Nov 4, 2024

@romainmenke Please take a look, if you have some time.

@romainmenke
Copy link
Member

Haven't had much time :/
I will review this in the coming days

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍


Sorry it took a while to get to this :)

@mhassan1 mhassan1 merged commit 1f7111b into main Nov 14, 2024
27 of 28 checks passed
@mhassan1 mhassan1 deleted the iterator-helpers-fix branch November 14, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants