Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blend square background color with focus/selection colors. #203

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

jpd236
Copy link
Contributor

@jpd236 jpd236 commented Dec 26, 2022

Previously, focused or selected cells would be colored with the appropriate color regardless of the cell background, which causes shaded cells to lose their contrast against other cells in the puzzle. This can interfere with solving, as it is important to be able to tell which cells are shaded in a focused word.

We adopt an approach from crosswordnexus/html5-crossword-solver#91: if a focused or selected cell has a non-white background, we blend the background color with the focus/selection color to determine the cell color. We darken the background color when blending to ensure sufficient contrast.

This should resolve much of #178. Cell background images will still be hidden when focused/selected; these are significantly rarer and harder to handle.

@mrichards42 mrichards42 merged commit ce16297 into mrichards42:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants