fix(extension): Fix lazy.nvim extension from breaking change upstream #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
folke
reviewed
Oct 17, 2023
| for _, plugin in pairs(LazyNvimConfig.plugins) do | ||
| local keys = Handler.handlers.keys:values(plugin) | ||
| local keys = Handler.handlers.keys:_values(Plugin.values(plugin, 'keys', true), plugin) |
There was a problem hiding this comment.
It's better to use the below instead:
local keys = plugin._.handlers.keys or {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #408
How to Test
Testing for Regressions
I have tested the following:
legendary.nvimin all modes (normal, insert, visual)legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)legendary.nvimin all modes (normal, insert, visual)legendary.nvim, then running the command manually from the command lineaugroup/autocmds created throughlegendary.nvimwork correctly