Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frecency)!: Use byte strings for DB IDs #473

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

mrjones2014
Copy link
Owner

Resolves: #472

How to Test

  1. Note that existing frecency data will unfortunately be invalid because the ID algorithm changed.
  2. Try an item with a '' and/or " in the description e.g.
return {
    'kylechui/nvim-surround',
    version = "*", -- Use for stability; omit to use `main` branch for the latest features
    keys = {
        { "<leader>'", '<Cmd>normal cs"\'<CR>', desc = 'Change surrounding " to \'' },
        { '<leader>"', '<Cmd>normal cs\'"<CR>', desc = 'Change surrounding \' to "' },
    },
    config = function ()
        require('nvim-surround').setup({ })
    end
}

with lazy_nvim extension and the frecency sorting enabled.

Testing for Regressions

I have tested the following:

  • Triggering keymaps from legendary.nvim in all modes (normal, insert, visual)
  • Creating keymaps via legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)
  • Triggering commands from legendary.nvim in all modes (normal, insert, visual)
  • Creating commands via legendary.nvim, then running the command manually from the command line
  • augroup/autocmds created through legendary.nvim work correctly

@mrjones2014 mrjones2014 changed the title fix!(frecency): Use byte strings for DB IDs fix(frecency)!: Use byte strings for DB IDs Sep 6, 2024
@mrjones2014 mrjones2014 merged commit 1d6f444 into master Sep 9, 2024
2 checks passed
@mrjones2014 mrjones2014 deleted the mrj/472/fix-db-ids branch September 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: sqlite error when description contains '
1 participant