Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MariaDB Version check/comparing #193

Closed

Conversation

Bodenhaltung
Copy link
Contributor

@Bodenhaltung Bodenhaltung commented Feb 6, 2024

Description

Checking and Comparing versions failed because of the output from mariadb -V changed in the past it is still broken for 10.x and 11.x.

11.x
mariadb -V
mariadb from 11.2.2-MariaDB, client 15.2 for debian-linux-gnu (x86_64) using readline EditLine wrapper
10.x
mariadb -V
mariadb  Ver 15.1 Distrib 10.11.6-MariaDB, for debian-linux-gnu (x86_64) using  EditLine wrapper

This PR fixed the issue for the latest, 11.x MariaDB Version.

In a perfect world there is a need for a version check for the version check?!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eRadical
Copy link
Collaborator

Hi @Bodenhaltung,

Thank you for the contribution but I think we should wait for this change.

Rationale:

It appears that MariaDB changed the version string from 10.x to 11.y:

preda@fedora:~$ docker run -it mariadb:10.5 /usr/bin/mariadb -V
/usr/bin/mariadb  Ver 15.1 Distrib 10.5.24-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
preda@fedora:~$ docker run -it mariadb:10.6 /usr/bin/mariadb -V
/usr/bin/mariadb  Ver 15.1 Distrib 10.6.17-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
preda@fedora:~$ docker run -it mariadb:10.7 /usr/bin/mariadb -V
/usr/bin/mariadb  Ver 15.1 Distrib 10.7.8-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
preda@fedora:~$ docker run -it mariadb:10.8 /usr/bin/mariadb -V
/usr/bin/mariadb  Ver 15.1 Distrib 10.8.8-MariaDB, for debian-linux-gnu (x86_64) using  EditLine wrapper
preda@fedora:~$ docker run -it mariadb:10.9 /usr/bin/mariadb -V
/usr/bin/mariadb  Ver 15.1 Distrib 10.9.8-MariaDB, for debian-linux-gnu (x86_64) using  EditLine wrapper
preda@fedora:~$ docker run -it mariadb:10.10 /usr/bin/mariadb -V
/usr/bin/mariadb  Ver 15.1 Distrib 10.10.7-MariaDB, for debian-linux-gnu (x86_64) using  EditLine wrapper
preda@fedora:~$ docker run -it mariadb:10.11 /usr/bin/mariadb -V
/usr/bin/mariadb  Ver 15.1 Distrib 10.11.7-MariaDB, for debian-linux-gnu (x86_64) using  EditLine wrapper
preda@fedora:~$ docker run -it mariadb:11.0 /usr/bin/mariadb -V
/usr/bin/mariadb from 11.0.5-MariaDB, client 15.2 for debian-linux-gnu (x86_64) using  EditLine wrapper
preda@fedora:~$ docker run -it mariadb:11.1 /usr/bin/mariadb -V
/usr/bin/mariadb from 11.1.4-MariaDB, client 15.2 for debian-linux-gnu (x86_64) using  EditLine wrapper
preda@fedora:~$ docker run -it mariadb:11.2 /usr/bin/mariadb -V
/usr/bin/mariadb from 11.2.3-MariaDB, client 15.2 for debian-linux-gnu (x86_64) using  EditLine wrapper
preda@fedora:~$ docker run -it mariadb:11.3-rc /usr/bin/mariadb -V
/usr/bin/mariadb from 11.3.1-MariaDB, client 15.2 for debian-linux-gnu (x86_64) using  EditLine wrapper

If you look at https://mariadb.org/download/ in section "Release schedule" you will see that

  • versions 10.4, 10.5, 10.6 & 10.11 are long term releases
  • versions 10.10, 11.y are short term releases
  • version 11.4 is still under development and also marked as a short term release
  • a long term release for 11.y series (https://mariadb.com/kb/en/mariadb-server-release-dates/) is yet to come...

I think we should keep the role compatible w/ the latest long term release.
@mrlesmithjr && @elcomtik » thoughts?

@mrlesmithjr
Copy link
Owner

@eRadical - I do agree we should focus on supporting long-term releases.

@Bodenhaltung
Copy link
Contributor Author

Ok, got your point(s), this PR was more self centered motivated like "works for me", I didn't research about long term releases. Sorry!

@Bodenhaltung Bodenhaltung deleted the fix-versions-check branch February 17, 2024 19:43
@eRadical
Copy link
Collaborator

No need for sorry.

If you can make a PR that considers 10.x and 11.y differently I think we can work w/ that.
We will just w8 4 a stable version of 11.y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants