Use RegExp to detect installed MariaDB version #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we should merge this despite debian12 failing. As it is failing for a while. @elcomtik || @mrlesmithjr - thoughts? |
elcomtik
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the issue linked below for all related background information.
I figured out a regular expression that works for both of the example outputs I have outlined in the issue; it assumes that there's always a
-MariaDBat the end of a substring that has the version number right in front of it.I have only tested this with my setup, which is MariaDB 11.4 on Debian 12.
Related Issue
Fixes #222
Types of changes