Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP firebase setup when compiling app in xcode #34

Closed
wants to merge 3 commits into from
Closed

WIP firebase setup when compiling app in xcode #34

wants to merge 3 commits into from

Conversation

arnaugomez
Copy link
Contributor

@arnaugomez arnaugomez commented Jan 29, 2024 •
edited
Loading

Connection with issue(s)

Resolve issue #33

The fix consists in:

  1. Bumping minimum iOS version from 11 to 12
  2. Changing the order of the build steps in the Xcodeconfig file.

Testing and Review Notes

Warning: tests are not expected to pass until #32 is merged

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@arnaugomez arnaugomez requested a review from hazzo January 29, 2024 13:55
@arnaugomez arnaugomez self-assigned this Jan 29, 2024
@arnaugomez arnaugomez mentioned this pull request Jan 29, 2024
Closed
hazzo
hazzo reviewed Jan 31, 2024
View reviewed changes
ios/Podfile Outdated Show resolved Hide resolved
@arnaugomez arnaugomez marked this pull request as ready for review February 1, 2024 09:16
@hazzo
Copy link
Contributor

hazzo commented Feb 5, 2024

iOS working correctly in main branch. Main branch udpated deps and flutter. Closing this.

@hazzo hazzo closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzo hazzo hazzo left review comments

Assignees

@arnaugomez arnaugomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaugomez @hazzo