Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add int64 dtype #48

Closed
wants to merge 1 commit into from
Closed

fix: Add int64 dtype #48

wants to merge 1 commit into from

Conversation

jslok
Copy link

@jslok jslok commented Feb 5, 2024

Fixes the error Unsupported tensor datatype! int64

@mrousavy
Copy link
Owner

mrousavy commented Feb 5, 2024

Fixes the error Unsupported tensor datatype! int64

Did you test your PR? Int64Array does not exist in JavaScript. This will not work.

I created #49 instead, this uses BigInt64Array and BigUint64Array 👍

@mrousavy mrousavy closed this Feb 5, 2024
@jslok jslok deleted the fix/support-int64-dtype branch February 6, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants