Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOs binaries updated to handle Simulator and Device builds #81

Closed
wants to merge 7 commits into from
Closed

iOs binaries updated to handle Simulator and Device builds #81

wants to merge 7 commits into from

Conversation

JoaoPauloCMarra
Copy link

Binarie used:
TensorFlowLiteC.podspec.json

related to issues: #35 #74 #75

@mrousavy
Copy link
Owner

hey - wow this is cool! can you confirm that this PR builds for you both on an actual iPhone device, and on the Simulator?

@mrousavy
Copy link
Owner

mrousavy commented Aug 16, 2024

How did you compile those bins? Or did you download them from the link in the podspec you shared?

@JoaoPauloCMarra
Copy link
Author

hey - wow this is cool! can you confirm that this PR builds for you both on an actual iPhone device, and on the Simulator?

It worked for me on both ios device and simulator and eas build.
Yea I got them from the URL in the podspec:

https://dl.google.com/tflite-nightly/ios/prod/tensorflow/lite/release/ios/nightly/794/20230212-035010/TensorFlowLiteC/0.0.1-nightly.20230212/TensorFlowLiteC-0.0.1-nightly.20230212.tar.gz

For now I run a patch to do the same as the PR whenever I install/re-install with --force
Screenshot 2024-08-16 at 09 24 34

Screenshot 2024-08-16 at 09 25 29
locally I log to make sure the patch worked but I removed this log from this PR

@JoaoPauloCMarra
Copy link
Author

JoaoPauloCMarra commented Aug 16, 2024

There is a new one from 25min ago:
https://dl.google.com/tflite-nightly/ios/prod/tensorflow/lite/release/ios/nightly/1359/20240816-035010/TensorFlowLiteC/0.0.1-nightly.20240816/TensorFlowLiteC-0.0.1-nightly.20240816.tar.gz

I will try It out and update the PR with It If everything goes well.

Results:

bun expo prebuild --clean:
ios-prebuild

Simulator:
simulator

Device:
Screenshot 2024-08-16 at 10 03 44

@drewandre
Copy link

Hi @JoaoPauloCMarra - is there a reason this PR is closed? Our team would love to pull in these changes since we are unable to build on iOS simulators. Thank you!

@mrousavy
Copy link
Owner

I think this PR handles that now: #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants