Skip to content
This repository has been archived by the owner on Jun 16, 2019. It is now read-only.

fix issues Attempt to use a destroyed view: detectChanges in renderValue #1434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

perjerz
Copy link

@perjerz perjerz commented Jan 1, 2019

image

image

I have an error of detectChanges in renderValue function, to solve this problem just check view is destroyed before call detectChanges function.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 96.259% when pulling eae7580 on perjerz3434:master into 0b8f559 on mseemann:master.

@mseemann
Copy link
Owner

mseemann commented Jan 3, 2019

hi. thx for your contribution.

the solution for your problem may solve your problem but i think it isn't a general solution. The question is: why is the renderValue method is called after the component is destroyed.

I would suggest do the following:

  • write a test that reproduces the error
  • find the reason why the renderValue method is called after the component is destroyed
  • fix this problem - e.g. make the test pass

Let me know if you need any help.

@perjerz
Copy link
Author

perjerz commented Jan 23, 2019

When mdl-select is used with *ngIf, it is possible to cd.detectChanges() with componet has already destroyed which produce a bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants