Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos and clarify messages in English translations #112

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katnova
Copy link

@katnova katnova commented Oct 9, 2024

Improved the accuracy and clarity of various English translation strings in the translation.json file. This includes fixing typos, improving grammar, and refining the phrasing of user-facing messages.

I don't know what the context is for a good number of these yet, so there's quite a few weird ones in here still.

Improved the accuracy and clarity of various English translation strings in the `translation.json` file. This includes fixing typos, improving grammar, and refining the phrasing of user-facing messages.

Signed-off-by: katnova <[email protected]>
@moonrailgun
Copy link
Contributor

Hi can you change source code rather then change translation file? its will very helpful to make sure data consistency.

@katnova
Copy link
Author

katnova commented Oct 13, 2024

Hi can you change source code rather then change translation file? its will very helpful to make sure data consistency.

Can you explain what you mean by that? The README.md says to update the files in src/client/public/locales.

If that's not where changes should be made, where should they be made?

@1Luc1
Copy link
Contributor

1Luc1 commented Dec 11, 2024

It seems you have to change the message directly within the source code. For instance:
'Please Select Workspace' -> 'Please Select a Workspace'

See

return <div>{t('Please Select Workspace')}</div>;

There you have to change the message(s).

As stated within the README.md; this will be extracted and translated with chatgpt.

...
pnpm run translation:extract
pnpm run translation:translate # this will call chatgpt to run auto translation, so you need set env `OPENAPI_KEY` to make sure run correct
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants