Graphs for Dashboard #69
Conversation
|
Also implemented the logic that if a Monitor is a Ping Monitor, it doesnt have the graph property |
There was a problem hiding this comment.
Yeah, thanks your change but its break too much things.
and i think click is not a good idea, because not all people wanna show it.
the best way for it is add a page options to switch it, if people want it.(without click, because no one will know it at first).
(here):
the other thing is trpc.monitor.data not a public request. because we dont wanna everyone can visit all data, because maybe its a private data. we should have a new route if we wanna show to public and check is this monitor under current page
docker-compose.yml
Outdated
There was a problem hiding this comment.
emmmm why delete docker compose file?
There was a problem hiding this comment.
i deleted it locally because i had another one and there were conflicts, my bad
There was a problem hiding this comment.
what is those 4 file for?
There was a problem hiding this comment.
idk where they came from, i think when i built the project those just popped up
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
i think you should not submit this file
| @@ -157,7 +157,8 @@ export const MonitorDataChart: React.FC<{ monitorId: string }> = React.memo( | |||
|
|
|||
| return ( | |||
| <div> | |||
| <div className="mb-4 text-right"> | |||
| <Area {...config} /> | |||
There was a problem hiding this comment.
i think you need prettier.
| @@ -157,7 +157,8 @@ export const MonitorDataChart: React.FC<{ monitorId: string }> = React.memo( | |||
|
|
|||
| return ( | |||
| <div> | |||
| <div className="mb-4 text-right"> | |||
| <Area {...config} /> | |||
There was a problem hiding this comment.
i think you need prettier.
and why move its order?
| // onClick={onClick} | ||
| onClick={() => { | ||
| setShowGraph(!showGraph); | ||
| }} |
There was a problem hiding this comment.
this not a good idea because you break normal list logic.
here:
|
|
||
| // Add the MonitorDataChart component to be shown | ||
| export const MonitorDataChartComponent = () => { | ||
| return <MonitorDataChart />; |
There was a problem hiding this comment.
we dont need dashboard anymore
|
Okay so except those issues, from the design just taking the already existing chart is fine? |
yeah, current chart is enough. did you have other idea? |
well my first Intuition was chartjs or sonething else but that would just be annoying to implement imo. If there is already a chart in the same design why not use it |
|
👍 free feel to re request again after you fixed all problem |
please, can u continue this, i really think this is a good idea |
I am working on it, but i have internet problems at home so i dont have much time. But I am going to work on it |
i hope the best for you, good luck :) |
Added:
Changed:
Mainly (thank youuuu) done by: @Devsider, a good friend of mine.
Just imagine the timespan dropdown below the chart.
And it's better looking than that screenshot, but it's really late here so I won't bother to make new screenshots today.