-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circleci to actions #15
Conversation
AlexNDRmac
commented
Oct 5, 2023
- Migrated from CircleCi to Github Actions Switch from circle CI to Github Actions #13
- Updated Readme (added license block)
Signed-off-by: AlexNDRmac <[email protected]>
Signed-off-by: AlexNDRmac <[email protected]>
.github/workflows/main.yml
Outdated
@@ -0,0 +1,40 @@ | |||
name: CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name the file ci.yml
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure :)
.github/workflows/main.yml
Outdated
- name: Setup Go | ||
uses: actions/setup-go@v4 | ||
with: | ||
go-version: 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the go.mod
file we are using 1.12
currently.
Can you either update this here to also use 1.12
(not sure this is still supported by this action) or update the go version in the go.mod
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With go 1.12 tests was failed, so I've bumped version, because test package want's 1.20.
I'll try to update go version to 1.20
Signed-off-by: AlexNDRmac <[email protected]>
Signed-off-by: AlexNDRmac <[email protected]>
Signed-off-by: AlexNDRmac <[email protected]>
Signed-off-by: AlexNDRmac <[email protected]>
all have done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thank you 🙏