Fix Request Proxy #637
Closed
Fix Request Proxy #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may have been solved by #639 |
|
@mikicho, thanks for raising this. I believe this might be fixed by #639, just like @kanadgupta suggests. Could you please bump it in Nock and let me know if the issue still persists? Thanks. |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nock/nock#2780
Added failing test.
@kettanaito the root cause is that we use the
kRawHeadersto populate theheaders.Do you have any thoughts on how to solve this conflict? I might be able to sort this out later this week, but right now I'm not sure about the best way to proceed.