fix: bundle browser build #1988
Conversation
|
Weird, looks like this breaks ts compat for some reason, and some failing tests. Weird, because locally the output seems to work fine in my unit tests and local storybook. Ill have to dive into that later, if someone else wants to continu this feel free to pick it up :) |
tsup.config.ts
Outdated
| format: ['esm', 'cjs'], | ||
| outDir: './lib/browser', | ||
| bundle: true, | ||
| splitting: false, | ||
| sourcemap: true, | ||
| dts: true, | ||
| noExternal: Object.keys(packageJson.dependencies), |
There was a problem hiding this comment.
This introduces an impossible state. noExternal, I imagine, takes precedence over external, and so we end up bundling ecosystem dependencies. Is that the case?
|
I've excluded the core modules from being bundled for the browser and browser tests pass locally. I believe that's the right direction here if we want the right TypeScript (and perhaps even runtime) behavior. I'd love to see if this change as-is gives any improvements on one of those fancy graphs of yours, @thepassle 🙏 |
|
@thepassle, if you have a moment to look at this, I'd be thankful. I'd love to release this alongside #1990. Thanks! |
Released: v2.1.4 🎉This has been released in v2.1.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
No description provided.