Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [jumpdrive] support #11

Merged
merged 11 commits into from
Dec 31, 2024
Merged

Add [jumpdrive] support #11

merged 11 commits into from
Dec 31, 2024

Conversation

BuckarooBanzay
Copy link
Member

adds support for the jumpdrive mod (needs testing)

fixes #9

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Aug 10, 2023
@OgelGames
Copy link
Contributor

Probably should add the fleet controller too :)

@OgelGames OgelGames added mod support Request or PR for adding or extending mod support and removed enhancement New feature or request labels Aug 10, 2023
@SwissalpS
Copy link
Contributor

SwissalpS commented Dec 23, 2024 •
edited
Loading

Problem: when placing JD, the radius is reset to 5.
The digiline channel is restored but not shown in formspec. (Shows up after some action occurs, like pressing "show" button.)

Edit: resolved with d3d64ae

@SwissalpS SwissalpS marked this pull request as ready for review December 24, 2024 09:01
@SwissalpS
Copy link
Contributor

The coordinate fields don't update on placement. I'm leaning toward calling that a feature.
Also I experimented with the owned field set, but decided not to use it. This way anybody in protection can pick up a drive/controller and swap it out.

Ownership remains set to original placer -> one can give landing privs to other players.
I'm not sure whether that is a good or bad thing. This has been possible in the past, now it just makes it even more portable.

SwissalpS
SwissalpS approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@SwissalpS SwissalpS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

S-S-X
S-S-X reviewed Dec 24, 2024
View reviewed changes
.luacheckrc Outdated Show resolved Hide resolved
@OgelGames OgelGames changed the title add jumpdrive:engine support Add [jumpdrive] support Dec 31, 2024
@SwissalpS SwissalpS merged commit accb035 into master Dec 31, 2024
2 checks passed
@SwissalpS SwissalpS deleted the jumpdrive-support branch December 31, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-S-X S-S-X S-S-X left review comments

@SwissalpS SwissalpS SwissalpS approved these changes

@OgelGames OgelGames Awaiting requested review from OgelGames

Assignees
No one assigned
Labels
mod support Request or PR for adding or extending mod support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maybe jumpdrives too?
4 participants
@BuckarooBanzay @OgelGames @SwissalpS @S-S-X