Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [wine] support #31

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Add [wine] support #31

merged 3 commits into from
Dec 31, 2024

Conversation

SwissalpS
Copy link
Contributor

@SwissalpS SwissalpS commented Dec 27, 2024

This doesn't work as long as [wine] uses core.rotate_node as the on_place event as that prevents after_place_node from being called.

@SwissalpS SwissalpS added the mod support Request or PR for adding or extending mod support label Dec 27, 2024
@OgelGames

This comment was marked as outdated.

@SwissalpS
Copy link
Contributor Author

wrenches after_place is indirectly a replacement for after_place_node
see:

wrench/api.lua

Lines 37 to 39 in 11c7d7e

minetest.override_item(name, {
after_place_node = function(...)
if not wrench.restore_node(...) and old_after_place then

Looks like tenplus1 has changed barrels since, I'll get back to this once I'm done with [smartshop].

@OgelGames
Copy link
Contributor

Oh, I completely mixed up the callbacks, you meant after_place_node never gets called by core.rotate_node... Yeah that is a problem.

@SwissalpS SwissalpS marked this pull request as ready for review December 31, 2024 19:09
@SwissalpS SwissalpS merged commit cba3b93 into master Dec 31, 2024
2 checks passed
@SwissalpS SwissalpS deleted the wineSupport branch December 31, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod support Request or PR for adding or extending mod support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants