Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smallest area at given position #74

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Use smallest area at given position #74

merged 2 commits into from
Sep 13, 2024

Conversation

SwissalpS
Copy link
Contributor

@SwissalpS SwissalpS commented Sep 3, 2024

In a scenario where areas are enclosed by other areas, usually users expect the smallest area to be the ruling one.
This PR addresses this.

Note: needs update of [areas] first, see minetest-mods/areas#79

Evaluate protection based on smallest area as that is what
most users seem to expect to be happening.
@SwissalpS SwissalpS added the enhancement New feature or request label Sep 3, 2024
@SwissalpS SwissalpS marked this pull request as ready for review September 11, 2024 20:07
@SwissalpS
Copy link
Contributor Author

[areas] #79 was merged, so ready for review here.

@OgelGames OgelGames merged commit 93e4f6a into master Sep 13, 2024
2 checks passed
@OgelGames OgelGames deleted the useSmallestArea branch September 13, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants